-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirects additional details button target URL on crashes page. #5798
Conversation
|
||
sendNowButton.remove(); | ||
fileBugButton.onclick = () => fileBug(crash.id, os, version); | ||
+ fileBugButton.remove(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should redirect the url to brave-browser issues, but if are going to remove the button I think it can be hidden in css without patching cc @petemill
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a polymer page, so we need to patch in a crashes_overrides.js
or a crashes_overrides.css
include to the .html, and remove or hide the button through one of those.
I agree we can have this pre-fill an issue on github via query params similar to what it looks like chromium is doing But if you want to hide it in this PR and create a new issue for that functionality, I think that would be fine too cc @rebron |
d6bd7d2
to
8916603
Compare
Either hide or redirect to github is fine. Thanks for the pointer @petemill |
8916603
to
416f8a8
Compare
On Crashes page after submitting a crash a button appears that allows submit a bug with additional details. Instead of directing the user to bugs.chromium.org we will redirect them to github.com/brave/brave-browser/issues/new and prefill some of the issue info. Fixes brave/brave-browser#10185
416f8a8
to
d049e3e
Compare
@@ -67,6 +97,9 @@ int OnBeforeURLRequest_CommonStaticRedirectWorkForGURL( | |||
URLPattern::SCHEME_HTTP | URLPattern::SCHEME_HTTPS, kChromeCastPrefix); | |||
static URLPattern clients4_pattern( | |||
URLPattern::SCHEME_HTTP | URLPattern::SCHEME_HTTPS, kClients4Prefix); | |||
static URLPattern bugsChromium_pattern( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bugs_chromium_pattern
Redirects additional details button target URL on crashes page.
Redirects additional details button target URL on crashes page.
Verification PASSED on
Created the following crashes and ensured they appeared in
As per the above, redirecting from |
Fixes brave/brave-browser#10185
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.