Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Wayback machine infobar view design #5840

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jun 15, 2020

Info bar graphic is replaced and separator between graphic and text is removed.

Resolves brave/brave-browser#8959

Screen Shot 2020-06-15 at 10 22 46 AM

Screen Shot 2020-06-17 at 10 33 52 AM

Screen Shot 2020-06-17 at 9 35 52 AM

Screen Shot 2020-06-17 at 10 34 03 AM

Submitter Checklist:

Test Plan:

  1. Visit brave.com/bo and check new image is displayed

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 1.12.x - Nightly milestone Jun 15, 2020
@simonhong simonhong self-assigned this Jun 15, 2020
@simonhong simonhong force-pushed the update_wayback_machine_infobar_design branch from 5d96337 to 640304e Compare June 17, 2020 00:37
Copy link

@karenkliu karenkliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonhong Looks great! 🎉 The only feedback I have is the icon on dark theme looks like the wrong color. The gradient should be lighter for better accessibility; please make the icon in dark theme this color: linear-gradient(314.42deg, #FA7250 6.04%, #FF1893 44.31%, #A78AFF 100%);

Info bar graphic is replaced and separator between graphic and text is removed.
@simonhong simonhong force-pushed the update_wayback_machine_infobar_design branch from 640304e to 22c38e0 Compare June 17, 2020 01:38
@simonhong simonhong requested a review from karenkliu June 17, 2020 01:39
Copy link

@karenkliu karenkliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

@simonhong
Copy link
Member Author

Merged because only test-install step is failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] "404 Sorry, that page is missing." banner shows up when the server returns 'Internal Server Error'
2 participants