-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements new persona api #6000
Conversation
f7f7f6b
to
e28b725
Compare
7b7e68c
to
214399b
Compare
16ebe5d
to
02039ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 1 duped line that needs removal but everything else looks good
vendor/brave-ios/Ledger/Models/BATExternalWallet+DictionaryValue.mm
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/common/security_helper.cc
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/common/security_helper.cc
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/wallet/wallet_recover.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/wallet/wallet_recover.cc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ads code lgtm
vendor/bat-native-ledger/src/bat/ledger/internal/common/security_helper.cc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5150f70
to
5aa7700
Compare
@NejcZdovc can you please add Android specific test plan. Issue is marked to be checked on Android as well |
@srirambv everything should go with Android except plan 1 where you can ignore step 3 |
Resolves brave/brave-browser#8428
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
plan 1:
brave.rewards.wallet
haspayment_id
andseed
populatedplan 2:
plan 3:
plan 4:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.