Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase size of rewards panel alert notification close icon #6033

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Jul 8, 2020

Resolves brave/brave-browser#10378

Submitter Checklist:

Test Plan:

I'm currently unsure of how to make a rewards panel alert appear when manually testing. When the alert message is displayed, the close "x" icon should display with the size pictured below:

Screen Shot 2020-07-08 at 1 08 32 PM

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@zenparsing zenparsing added feature/rewards CI/skip Do not run CI builds (except noplatform) labels Jul 8, 2020
@zenparsing zenparsing self-assigned this Jul 8, 2020
@zenparsing zenparsing force-pushed the ksmith-wallet-unreachable-x branch from 082e6ed to bc5050e Compare July 8, 2020 17:07
@zenparsing zenparsing merged commit a1b4788 into master Jul 8, 2020
@zenparsing zenparsing deleted the ksmith-wallet-unreachable-x branch July 8, 2020 18:36
@NejcZdovc NejcZdovc added this to the 1.12.x - Beta milestone Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform) feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Make Rewards message close button more visible
2 participants