Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix for crash on Sync settings when rewards are not available #6205

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Jul 24, 2020

Resolves brave/brave-browser#10915

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jul 24, 2020
@samartnik samartnik added this to the 1.13.x - Nightly milestone Jul 24, 2020
@samartnik samartnik self-assigned this Jul 24, 2020
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@kjozwiak
Copy link
Member

Reproduced the issue on 1.11.93 CR: 84.0.4147.68 using a Pixel XL API 30 x86 AVD as per the following:

Screen Shot 2020-07-27 at 12 58 33 AM

Screen Shot 2020-07-27 at 12 54 49 AM

Verification PASSED on 1.13.45 CR: 84.0.4147.89 using a Pixel XL API 30 x86 AVD as per the following:

Working Example Working Example
Screen Shot 2020-07-27 at 1 01 47 AM Screen Shot 2020-07-27 at 1 02 37 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Crash on attempt to open Sync settings when rewards are not available
3 participants