-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pulseaudio: Register as Brave instead of Chromium #6209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging both @fmarier and @antonok-edm to take a look since you both use Linux. |
fmarier
approved these changes
Jul 24, 2020
antonok-edm
approved these changes
Jul 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed this works correctly for me
kkuehlz
force-pushed
the
pulseaudio_application_brave
branch
2 times, most recently
from
July 27, 2020 18:05
ee22579
to
0c0698f
Compare
bridiver
reviewed
Jul 27, 2020
When creating a new pulseaudio context, make the application name Brave instead of Chromium. Resolves brave/brave-browser#10919
kkuehlz
force-pushed
the
pulseaudio_application_brave
branch
from
July 27, 2020 19:34
0c0698f
to
a1c5996
Compare
CI passes except for |
bridiver
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new pulseaudio context, make the application name Brave
instead of Chromium.
Resolves brave/brave-browser#10919
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Play a song on linux and use the
pavucontrol
application to see that it is playing from Brave instead of Chromium.Reviewer Checklist:
After-merge Checklist:
changes has landed on.