Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for crash in CanvasAsyncBlobCreator (uplift to 1.12.x) #6360

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 6, 2020

Uplift of #6320
Resolves brave/brave-browser#10913

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team August 6, 2020 17:00
@brave-builds brave-builds self-assigned this Aug 6, 2020
@brave-builds brave-builds added this to the 1.12.x - Release milestone Aug 6, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Aug 6, 2020

Restarting Android as we lost the spot instance/agent was removed as per https://ci.brave.com/job/pr-brave-browser-pr6320_mpilgrim_canvasasyncblobcreator_1.12.x/1/execution/node/185/log/.

13:13:37  Cannot contact ecs-android-android-ecs-9vbbn: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@5465ff91:JNLP4-connect connection from ip-172-31-19-85.us-west-2.compute.internal/172.31.19.85:48402": Remote call on JNLP4-connect connection from ip-172-31-19-85.us-west-2.compute.internal/172.31.19.85:48402 failed. The channel is closing down or has closed down
15:12:02  Could not connect to ecs-android-android-ecs-9vbbn to send interrupt signal to process

Restarting Win x64 as we lost the spot instance/agent was removed as per https://ci.brave.com/job/pr-brave-browser-pr6320_mpilgrim_canvasasyncblobcreator_1.12.x/1/execution/node/144/log/:

14:02:52  Cannot contact i-04fa4ce9ccbab0e96: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@423802ba:i-04fa4ce9ccbab0e96": Remote call on i-04fa4ce9ccbab0e96 failed. The channel is closing down or has closed down
14:07:52  Could not connect to i-04fa4ce9ccbab0e96 to send interrupt signal to process

@kjozwiak kjozwiak added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Aug 6, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Aug 7, 2020

Restarting Win x64 as checking out the source failed as per https://ci.brave.com/job/pr-brave-browser-pr6320_mpilgrim_canvasasyncblobcreator_1.12.x/2/execution/node/293/log/.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.12.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit bb00c5b into 1.12.x Aug 7, 2020
@kjozwiak kjozwiak deleted the pr6320_mpilgrim_canvasasyncblobcreator_1.12.x branch August 7, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants