Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Gemini toggle option from settings when unsupported #6377

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Aug 7, 2020

Fixes: brave/brave-browser#11136

Submitter Checklist:

Test Plan:

Defined in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.14.x - Nightly milestone Aug 7, 2020
@ryanml ryanml requested review from bbondy and emerick August 7, 2020 23:04
@ryanml ryanml self-assigned this Aug 7, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml ryanml merged commit 5fb25dc into master Aug 10, 2020
@ryanml ryanml deleted the fix-11136 branch August 10, 2020 01:09
ryanml added a commit that referenced this pull request Sep 10, 2020
Removes Gemini toggle option from settings when unsupported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gemini toggle in brave://settings#newTab should not be available in unsupported regions
2 participants