Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes user funds claim (uplift to 1.13.x) #6453

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Aug 19, 2020

Uplift of #6442
Resolves brave/brave-browser#11298

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@NejcZdovc NejcZdovc added this to the 1.13.x - Beta milestone Aug 19, 2020
@NejcZdovc NejcZdovc requested a review from a team August 19, 2020 05:09
@NejcZdovc NejcZdovc self-assigned this Aug 19, 2020
@kjozwiak
Copy link
Member

Restarted all platforms using Build with Parameters due to each platform failing the following:

hudson.remoting.ProxyException: groovy.lang.MissingPropertyException: No such property: NODE_LABEL for class: WorkflowScript

@kjozwiak
Copy link
Member

Restarted Linux via https://ci.brave.com/job/brave-core-build-pr-linux/job/PR-6453/3/ as we lost the spot instance/agent was removed as per https://ci.brave.com/job/pr-brave-browser-user_funds_claim-1.13-linux/1/execution/node/101/log/.

11:21:29  Cannot contact i-0c45219c4699e2380: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@5e105594:i-0c45219c4699e2380": Remote call on i-0c45219c4699e2380 failed. The channel is closing down or has closed down
11:26:33  Could not connect to i-0c45219c4699e2380 to send interrupt signal to process

Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.13.x is approved after deliberating with @brave/uplift-approvers. QA has verified this PR on Nightly as per #6442 (comment)

@LaurenWags LaurenWags merged commit 821b06e into 1.13.x Aug 24, 2020
@LaurenWags LaurenWags deleted the user_funds_claim-1.13 branch August 24, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants