Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acommodates long translations for NTP settings button #6786

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Oct 6, 2020

Fixes brave/brave-browser#10946

Screen Shot 2020-10-06 at 3 29 09 AM

Submitter Checklist:

Test Plan:

Defined in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.17.x - Nightly milestone Oct 6, 2020
@ryanml ryanml self-assigned this Oct 6, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml ryanml merged commit eb0346c into master Oct 6, 2020
@ryanml ryanml deleted the fix-10946 branch October 6, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Add padding to Customize text to accomodate translations
2 participants