Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default in ShouldUseUserAgentOverride for OOPIF #6793

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Oct 6, 2020

Resolves brave/brave-browser#12020

Due to longstanding upstream bug https://bugs.chromium.org/p/chromium/issues/detail?id=426555, if you ask an OOPIF's client for its user agent, it does not respect the user agent override initiated in the tab helper, which we rely on for farbling. This patch changes the default in this case so that farbling will work in these cases.

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@pilgrim-brave pilgrim-brave self-assigned this Oct 6, 2020
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_fix_ua_remote_frame_farbling branch from e4354d4 to 92fbda9 Compare October 7, 2020 23:56
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_fix_ua_remote_frame_farbling branch from 72c0218 to b8946f9 Compare October 8, 2020 19:54
@pilgrim-brave pilgrim-brave merged commit cf18546 into master Oct 8, 2020
@pilgrim-brave pilgrim-brave deleted the mpilgrim_fix_ua_remote_frame_farbling branch October 8, 2020 22:34
@pilgrim-brave pilgrim-brave added this to the 1.17.x - Nightly milestone Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote frames not farbling user agent properly
2 participants