Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid crash by using proper origin. (uplift to 1.17.x) #6959

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Avoid crash by using proper origin. (uplift to 1.17.x) #6959

merged 1 commit into from
Oct 28, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Oct 27, 2020 •
edited by kjozwiak
Loading

Uplift of #6938
Resolves brave/brave-browser#12268

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team October 27, 2020 15:48
@brave-builds brave-builds self-assigned this Oct 27, 2020
@brave-builds brave-builds added this to the 1.17.x - Beta milestone Oct 27, 2020
kjozwiak
kjozwiak approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.17.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #6938 (comment).

@kjozwiak kjozwiak merged commit cc66693 into 1.17.x Oct 28, 2020
@kjozwiak kjozwiak deleted the pr6938_ie_origin_crash_1.17.x branch October 28, 2020 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.17.x - Release #1
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases