Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes save password prompt. #6989

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Fixes save password prompt. #6989

merged 1 commit into from
Oct 30, 2020

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#12398

Image files we were overriding got renamed.

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/39eded942d854f367be5bde332189a6a8271c76f

commit 39eded942d854f367be5bde332189a6a8271c76f
Author: Mohamed Amir Yosef [email protected]
Date: Tue Sep 22 17:27:02 2020 +0000

[Passwords] Update header image for different states in Save Bubble

As per the attached bug, here is the logic for changing the header image

- The illustration should change when the user switches between "Save to device" and "Sav  to account".
- In the Update bubble, the illustration should change based on where the update will go.
- If the update will go to both locations, use the "account" image.

Screencast:
Light mode: https://screencast.googleplex.com/cast/NjQxNjYzNjU3MzY0Njg0OHw0NTg2MTgzYy1kMw
Dark mode: https://screencast.googleplex.com/cast/NTY4MTQ3NTYxMTUyNTEyMHwzOTI4Y2JkYy1mZQ

Bug: 1115936

Resolves

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Fixes brave/brave-browser#12398

Image files we were overriding got renamed.

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/39eded942d854f367be5bde332189a6a8271c76f

commit 39eded942d854f367be5bde332189a6a8271c76f
Author: Mohamed Amir Yosef <[email protected]>
Date:   Tue Sep 22 17:27:02 2020 +0000

    [Passwords] Update header image for different states in Save Bubble

    As per the attached bug, here is the logic for changing the header image

    - The illustration should change when the user switches between "Save to device" and "Sav  to account".
    - In the Update bubble, the illustration should change based on where the update will go.
    - If the update will go to both locations, use the "account" image.

    Screencast:
    Light mode: https://screencast.googleplex.com/cast/NjQxNjYzNjU3MzY0Njg0OHw0NTg2MTgzYy1kMw
    Dark mode: https://screencast.googleplex.com/cast/NTY4MTQ3NTYxMTUyNTEyMHwzOTI4Y2JkYy1mZQ

    Bug: 1115936
@mkarolin mkarolin added this to the 1.18.x - Nightly milestone Oct 30, 2020
@mkarolin mkarolin self-assigned this Oct 30, 2020
@mkarolin mkarolin merged commit 9abb939 into master Oct 30, 2020
@mkarolin mkarolin deleted the maxk-fix-save-password-bubble branch October 30, 2020 13:39
mkarolin added a commit that referenced this pull request Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

save password prompt using Chrome's UI
2 participants