Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Brave Ads UI copy to "Ads received this month" - 1.18.x #7179

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Nov 18, 2020

Uplift of #7163
Resolves brave/brave-browser#12719

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.18.x - Beta milestone Nov 18, 2020
@tmancey tmancey requested a review from a team November 18, 2020 12:03
@tmancey tmancey self-assigned this Nov 18, 2020
@tmancey tmancey changed the title Updated Brave Ads UI copy to "Ads received this month" Updated Brave Ads UI copy to "Ads received this month" - 1.18.x Nov 18, 2020
@LaurenWags
Copy link
Member

Restarted macOS, Linux, Windows.

@kjozwiak
Copy link
Member

@tmancey looks like the above needs to be rebased.

@kjozwiak
Copy link
Member

Restarting Win x64 via https://ci.brave.com/job/pr-brave-browser-issues-12719-1.18.x-windows/4/ due to build failing as per https://ci.brave.com/job/pr-brave-browser-issues-12719-1.18.x-windows/3/execution/node/200/log/. Looks like there was issues with the node connectivity.

23:56:06  Cannot contact i-0cd34f3da7377796e-windows-swarm-5b16d365: hudson.remoting.RequestAbortedException: java.nio.channels.ClosedChannelException
00:01:06  Could not connect to i-0cd34f3da7377796e-windows-swarm-5b16d365 to send interrupt signal to process

Restarting macOS via https://ci.brave.com/job/pr-brave-browser-issues-12719-1.18.x-macos/4/ due to build failing as per https://ci.brave.com/job/pr-brave-browser-issues-12719-1.18.x-macos/3/execution/node/204/log/.

@kjozwiak
Copy link
Member

Win x64 failed the S3 upload due to missing source files as per https://ci.brave.com/job/pr-brave-browser-issues-12719-1.18.x-windows/4/execution/node/285/log/. However, quickly checked with @brave/releng and the above doesn't block uplift.

05:02:19  Uploading file:/C:/18.x/src/out/Release/brave_installer_87_1_18_61.exe to s3://****/brave-browser-build-pr/issues/12719-1.18.x/de9da66d58f61eed6bd9f5f525cf36b18f0ef801-2f43eb9f54e86026c4dfb9a8ac365f3f9bf19369/windows/ 
05:02:19  Upload failed due to missing source file

macOS failed test-browser due to several intermittent reward failures as per https://ci.brave.com/job/pr-brave-browser-issues-12719-1.18.x-macos/4/execution/node/251/log/. However, these are intermittent and don't block uplift.

04:23:21  4 tests failed:
04:23:21      RewardsBrowserTest.ActivateSettingsModal (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:119)
04:23:21      RewardsBrowserTest.UpholdLimitNoBAT (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:397)
04:23:21      RewardsContributionBrowserTest.TipUnverifiedPublisher (../../brave/components/brave_rewards/browser/test/rewards_contribution_browsertest.cc:303)
04:23:21      RewardsPromotionBrowserTest.PromotionRemovedFromEndpoint (../../brave/components/brave_rewards/browser/test/rewards_promotion_browsertest.cc:230)
04:23:21  2 tests timed out:
04:23:21      RewardsBrowserTest.BackupRestoreModalHasNotice (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:303)
04:23:21      RewardsPromotionBrowserTest.ClaimViaSettingsPage (../../brave/components/brave_rewards/browser/test/rewards_promotion_browsertest.cc:195)
04:23:21  1 test crashed:
04:23:21      RewardsBrowserTest.ToggleAutoContribute (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:130)

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.18.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #7163 (comment).

@kjozwiak kjozwiak merged commit f786d4e into 1.18.x Nov 25, 2020
@kjozwiak kjozwiak deleted the issues/12719-1.18.x branch November 25, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants