Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Yandex as default #7376

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Set Yandex as default #7376

merged 2 commits into from
Dec 8, 2020

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#12979

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Please follow main issue for test plan

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Dec 8, 2020
@deeppandya deeppandya added this to the 1.20.x - Nightly milestone Dec 8, 2020
@deeppandya deeppandya self-assigned this Dec 8, 2020

for (TemplateUrl templateUrl : templateUrls) {
if (templateUrl.getIsPrepopulated()
&& OnboardingPrefManager.searchEngineMap.get(templateUrl.getShortName())
!= null) {
Log.e("NTP", templateUrl.getShortName());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need that log anymore

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya deeppandya merged commit b22644c into master Dec 8, 2020
@deeppandya deeppandya deleted the make_yandex_default_android branch December 8, 2020 19:23
brave-builds pushed a commit that referenced this pull request Dec 8, 2020
brave-builds pushed a commit that referenced this pull request Dec 8, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Dec 9, 2020

Verification PASSED on Pixel 2 XL running Android 11 using the following build:

Brave | 1.20.19 Chromium: 87.0.4280.101 (Official Build) canary (32-bit)
--- | ---
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Android 11; Pixel 2 XL Build/RP1A.201005.004
  • ensured that Yandex was selected as the default search engine for the following locales:
    • Russia, Armenia, Belarus & Kyrgyz Republic
  • ensured that updating from 1.20.17 CR: 87.0.4280.88 --> 1.20.19 Chromium: 87.0.4280.101 didn't replace the previous default SE with Yandex

Note: Some of these regions don't have any localization but I ensured that:

  • Yandex is being set as the default
  • Yandex is available via the SE onboarding

Russia Examples

Example 1 Example 2
Screenshot_20201208-231549 Screenshot_20201208-231706

Armenia Examples

Example 1 Example 2
Screenshot_20201208-232543 Screenshot_20201208-232534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yandex not being set as the default search engine in specific regions
3 participants