Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable kVideoPlaybackQuality to fix webcompat issue #7437

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Dec 15, 2020

Fixes brave/brave-browser#13183

Manual revert of #4479

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bsclifton
Copy link
Member Author

NOTE: this is likely safe to merge, but I'll try to verify this does indeed work and address the problem before we accept (and potentially uplift)

@bsclifton
Copy link
Member Author

OK @ryanbr was kind enough to verify - please see brave/brave-browser#13183 (comment)

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton
Copy link
Member Author

iOS running into a reportedly intermittent problem not related to this PR; I created brave/brave-browser#13211 to track that

@bsclifton bsclifton added this to the 1.20.x - Nightly milestone Dec 15, 2020
@bsclifton bsclifton merged commit 4431b9f into master Dec 15, 2020
@bsclifton bsclifton deleted the bsc-revert-kVideoPlaybackQuality branch December 15, 2020 23:39
@bsclifton
Copy link
Member Author

bsclifton commented Dec 16, 2020

Will create uplifts to 1.19 and 1.18 (needs to be manual as this was done w/ Chromium 88 and uplift tool failed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple users reporting that HBO Max is broken, likely due to kVideoPlaybackQuality being disabled
3 participants