Brave ephemeral storage flag #7473
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using ephemeral storage for all unblocked third-party frame storage, only use ephemeral storage when third-party storage is blocked. This means that turning on the ephemeral storage flag will always replaced blocked storage in third-party frames with an ephemeral version, regardless of other settings.
mrobinson
reviewed
Dec 17, 2020
cathiechen
commented
Dec 18, 2020
| if (url::Origin::Create(url) == top_frame_origin) | ||
| return false; | ||
| return true; | ||
| return !cookie_settings->IsCookieAccessAllowed( |
There was a problem hiding this comment.
@mrobinson Do you think we should check IsCookieAccessOrEphemeralCookiesAccessAllowed first in this function?
There was a problem hiding this comment.
Do you mean to add a DCHECK here for that? If so, I think that'd be just fine.
There was a problem hiding this comment.
I meant
if (!IsCookieAccessOrEphemeralCookiesAccessAllowed())
return false;
RestrictedCookieManager::CookieListToGetAllForUrlCallback will check it. So no need to add it here.
Make sense. Sorry for the confusion. Let's move to #7207 I'll close this one:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed).Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on.
Test Plan: