Userlytics feedback android #7513
Conversation
deeppandya
added
CI/skip-linux
CI/skip-macos-x64
| * An internal version of {@link #addBookmarkSilently(Context, BookmarkModel, String, String)}. | ||
| * Will reset last used parent if it fails to add a bookmark | ||
| */ | ||
| private static BookmarkId addBookmarkInternal( |
There was a problem hiding this comment.
@samartnik Created an issue to add support for static functions. brave/brave-browser#13359 so instead of adding a patch, i have copied the function here.
There was a problem hiding this comment.
does that function somehow different of what we have inside BookmarkUtils.java? Why do we need to duplicate it as we can call it via that BookmarkUtils.addBookmarkInternal as it's static.
| @@ -0,0 +1,153 @@ | |||
| // Copyright 2020 The Chromium Authors. All rights reserved. | |||
| public BraveBookmarkUtilsClassAdapter(ClassVisitor visitor) { | ||
| super(visitor); | ||
| changeMethodOwner( | ||
| sBookmarkUtilsClassName, "addOrEditBookmark", sBraveBookmarkUtilsClassName); |
There was a problem hiding this comment.
Please add checks in testClassesExist and testMethodsExist in brave/android/javatests/org/chromium/chrome/browser/BytecodeTest.java
There was a problem hiding this comment.
And whitelist it for tests here brave/android/java/apk_for_test.flags
| changeMethodOwner( | ||
| sBookmarkUtilsClassName, "addOrEditBookmark", sBraveBookmarkUtilsClassName); | ||
| } | ||
| } |
| <solid android:color="@color/onboarding_bg_color"/> | ||
| <stroke android:width="1dp" android:color="#E9E9F4" /> | ||
| <corners android:radius="10dp"/> | ||
| </shape> |
| }, | ||
| Snackbar.TYPE_NOTIFICATION, Snackbar.UMA_BOOKMARK_ADDED) | ||
| .setSingleLine(false); | ||
| RecordUserAction.record("EnhancedBookmarks.AddingFailed"); |
There was a problem hiding this comment.
let's remove that, it's used to track user's activity in chrome
| return new SnackbarController() { | ||
| @Override | ||
| public void onDismissNoAction(Object actionData) { | ||
| RecordUserAction.record("EnhancedBookmarks.EditAfterCreateButtonNotClicked"); |
There was a problem hiding this comment.
the same as a previous comment about RecordUserAction
|
|
||
| @Override | ||
| public void onAction(Object actionData) { | ||
| RecordUserAction.record("EnhancedBookmarks.EditAfterCreateButtonClicked"); |
There was a problem hiding this comment.
the same as a previous comment about RecordUserAction
Resolves brave/brave-browser#11939
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed).Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on.
Test Plan: