Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more comments to BraveShieldsContentSettingSetFunction #763

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Oct 30, 2018

About why it handles js settings differently than others.

Close: brave/brave-browser#2326
This supplements #439

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

About why it handles js settings differently than others.
@simonhong simonhong self-assigned this Oct 30, 2018
@simonhong simonhong requested a review from yrliou October 30, 2018 01:01
@simonhong simonhong merged commit d496503 into master Nov 2, 2018
@simonhong simonhong deleted the add_comment_to_brave_shields_api_cc branch November 2, 2018 01:18
@bbondy
Copy link
Member

bbondy commented Nov 29, 2018

@simonhong each PR should close an issue. I can't tell which issue this is meant to close. The one mentioned seems to be in 0.55.x.

@simonhong
Copy link
Member Author

@bbondy Oh, I should use separate issue when PRs are merged separately. brave/brave-browser#2326 is created and pointed by this PR. Sorry!

@bbondy
Copy link
Member

bbondy commented Dec 3, 2018

np thanks!

@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more explanation to BraveShieldsContentSettingSetFunction::Run()
3 participants