Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop patch for template_url_service_factory.cc for chromium_src override #7980

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

mariospr
Copy link
Contributor

@mariospr mariospr commented Feb 17, 2021

Now that we're no longer relying on BRAVE_CHROMIUM_BUILD, we can have a
chromium_src override instead to define the Brave-specific behaviour
here, and drop this patch.

Fixes brave/brave-browser#14221

Resolves

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See Test plan from #310

Now that we're no longer relying on BRAVE_CHROMIUM_BUILD, we can have a
chromium_src override instead to define the Brave-specific behaviour
here, and drop this patch.

Fixes brave/brave-browser#14221
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@mariospr mariospr merged commit 0865e6f into master Feb 18, 2021
@mariospr mariospr deleted the issues/14221 branch February 18, 2021 09:11
@mariospr
Copy link
Contributor Author

Thanks, merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove patches/chrome-browser-search_engines-template_url_service_factory.cc.patch
2 participants