Add don't ask again checkbox to default browser prompt #8253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
changed the title
simonhong
changed the title
simonhong
force-pushed
the
default_browser_prompt
branch
from
0460237
to
e83134f
Compare
|
PTAL :) |
simonhong
force-pushed
the
default_browser_prompt
branch
from
e83134f
to
6bc3c97
Compare
mkarolin
reviewed
Apr 5, 2021
| #include "brave/grit/brave_generated_resources.h" | ||
| #include "chrome/browser/browser_process.h" |
There was a problem hiding this comment.
Need to add a dep on //chrome/browser:browser_process?
There was a problem hiding this comment.
karenkliu
reviewed
Apr 5, 2021
There was a problem hiding this comment.
Hi! Is there any way to use our checkbox and button component from the design system?
- Checkbox https://www.figma.com/file/z9wmg2FCwuXx9FLbDo5avJ/Platform-UI-Brave-desktop?node-id=105%3A244
- Buttons https://www.figma.com/file/z9wmg2FCwuXx9FLbDo5avJ/Platform-UI-Brave-desktop?node-id=1011%3A0
This dialog should look like this:
Default browser prompot is disabled if it's checked and user will not see this prompt anymore. This checking is stored in local state so new profile also can't see this prompt dialog anymore. fix brave/brave-browser#14469
simonhong
force-pushed
the
default_browser_prompt
branch
from
6bc3c97
to
8325553
Compare
@karenkliu I'll work on it as a separate task because it's global native ui change. |
|
@simonhong Okay - thanks! |
mkarolin
reviewed
Apr 6, 2021
|
Merged because previous CI run was all green and last commit is just grd file description text change. |
24 tasks
|
Why was this never fixed on Android as well? |
kylehickinson
pushed a commit
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default browser prompt is disabled if it's checked.
fix brave/brave-browser#14469
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
npm run test brave_browser_tests -- --filter=*BraveLocalStatePref*