Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MacOS] Override helper-alerts identifier for signing. #8755

Merged
merged 2 commits into from
May 12, 2021
Merged

[MacOS] Override helper-alerts identifier for signing. #8755

merged 2 commits into from
May 12, 2021

Commits on May 10, 2021

  1. [MacOS] Override helper-alerts identifier for signing. 

    Alerts helper has been added for signing upstream but Chrome doesn't
distribute it yet. Because it uses the same identifier as the current
alerts service, we get a signing error.

For now we'll use a different identifier for this helper and then
revert once Chrome starts distributing the helper.

Fixes brave/brave-browser#15731

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/56915522276f

commit 56915522276f86acc55f86b143b4d7b260d6bc36
Author: Richard Knoll <[email protected]>
Date:   Fri Mar 5 16:07:34 2021 +0000

    Introduce alert notification helper .app

    This adds a new helper .app on macOS to display alert notifications.
    This app is required to show alert style notifications as the main app
    can only show banner style ones and the XPC service can not use the new
    UNNotification APIs.

    Bug: 1127306
    @mkarolin
    mkarolin committed May 10, 2021
    Configuration menu
    Copy the full SHA
    be73472 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2021

  1. Pacify pylint for signing_helper.py

    @mkarolin
    mkarolin committed May 11, 2021
    Configuration menu
    Copy the full SHA
    c0afd8a View commit details
    Browse the repository at this point in the history