Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented IPFS import refactoring #8776

Merged
merged 1 commit into from
May 14, 2021
Merged

Implemented IPFS import refactoring #8776

merged 1 commit into from
May 14, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented May 11, 2021

Resolves brave/brave-browser#15758

Removed File/Text/Directory import classes, using base class instead
Move blob creation to network utilities to reuse it later
Avoid of base::Unretained

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • [ x] Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Check all IPFS import cases(text, link, web page, directory, file)

@spylogsster spylogsster force-pushed the import-refactoring branch 2 times, most recently from 91caa61 to 0d8223e Compare May 11, 2021 18:29
@spylogsster spylogsster requested a review from bbondy May 11, 2021 18:52
@spylogsster spylogsster force-pushed the import-refactoring branch 4 times, most recently from ef0ab36 to 573af8c Compare May 12, 2021 16:16
@spylogsster spylogsster changed the base branch from master to p2p-keys-import May 12, 2021 16:18
@spylogsster spylogsster force-pushed the import-refactoring branch 3 times, most recently from 736ad22 to dfe48d8 Compare May 12, 2021 16:45
Base automatically changed from p2p-keys-import to master May 14, 2021 06:17
@spylogsster spylogsster force-pushed the import-refactoring branch 12 times, most recently from 9c181d9 to 0f91343 Compare May 14, 2021 13:04
Removed File/Text/Directory import classes.
Use base class instead, moved blob creation to network utilities
@spylogsster spylogsster merged commit 6302bd6 into master May 14, 2021
@spylogsster spylogsster deleted the import-refactoring branch May 14, 2021 20:03
@spylogsster spylogsster added this to the 1.26.x - Nightly milestone May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant classes for import
2 participants