Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't register Brave as an ftp handler #8791

Merged
merged 1 commit into from
May 18, 2021
Merged

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented May 13, 2021

Resolves brave/brave-browser#15812

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Install the .deb / .rpm package.
  2. Check that brave is not associated with the ftp protocol: xdg-mime query default x-scheme-handler/ftp
  3. Check that grep x-scheme-handler/ftp /etc/mailcap does not include this line:
x-scheme-handler/ftp; /usr/bin/brave-browser-stable --incognito %s; test=test -n "$DISPLAY"

@fmarier fmarier requested a review from wknapik May 13, 2021 02:28
@fmarier fmarier requested a review from a team as a code owner May 13, 2021 02:28
@fmarier fmarier self-assigned this May 13, 2021
@fmarier
Copy link
Member Author

fmarier commented May 13, 2021

I intend to upstream this fix so the patch should go away in a future Chromium upgrade.

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@fmarier
Copy link
Member Author

fmarier commented May 18, 2021

Test failures on Linux are unrelated and will be addressed in #8845.

@fmarier fmarier added this to the 1.26.x - Nightly milestone May 18, 2021
@fmarier fmarier merged commit 5aca061 into master May 18, 2021
@fmarier fmarier deleted the remove-ftp-handler-15812 branch May 18, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop associating Brave with the ftp protocol
3 participants