Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Settings UI privacy page missing settings. #8800

Merged
merged 1 commit into from
May 14, 2021

Conversation

mkarolin
Copy link
Collaborator

Converted patches that were importing our html and adding our controls to
an override.

Fixes brave/brave-browser#15808

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Converted patches that were importing our html and adding our controls to
an override.

Fixes brave/brave-browser#15808
@mkarolin mkarolin requested a review from a team as a code owner May 13, 2021 16:59
@mkarolin mkarolin self-assigned this May 13, 2021
@mkarolin
Copy link
Collaborator Author

mkarolin commented May 13, 2021

CI Failures:

  • Linux: BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest browser tests crashes are known and unrelated to this PR.
  • MacOS: AdBlockServiceTest.CnameCloakedRequestsGetBlocked browser test crash is known and unrelated to this PR.

Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@mkarolin mkarolin merged commit 225e58b into master May 14, 2021
@mkarolin mkarolin deleted the maxk-fix-settings-ui-privacy-page branch May 14, 2021 16:21
@mkarolin mkarolin added this to the 1.26.x - Nightly milestone May 14, 2021
mkarolin added a commit that referenced this pull request May 18, 2021
Fixes Settings UI privacy page missing settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly CR91 major bump is missing 3 sections in Privacy and security
3 participants