Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync folder custom title #954

Merged
merged 2 commits into from
Nov 26, 2018
Merged

Sync folder custom title #954

merged 2 commits into from
Nov 26, 2018

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Nov 26, 2018

Fixes brave/brave-browser#2144.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
      Got 3 tests failed
2 tests failed:
    NavigatorPluginsTest.ConstMimeTypesWithFlash (../../brave/chromium_src/third_party/blink/renderer/modules/plugins/navigator_pluginstest.cc:112)
    NavigatorPluginsTest.ConstPluginsWithFlash (../../brave/chromium_src/third_party/blink/renderer/modules/plugins/navigator_pluginstest.cc:96)
1 test timed out:
    BraveExtensionProviderTest.PDFJSInstalls (../../brave/browser/extensions/brave_extension_provider_browsertest.cc:40)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Use steps from brave/brave-browser#2144

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@AlexeyBarabash
Copy link
Contributor Author

master: bb9cf49

AlexeyBarabash added a commit that referenced this pull request Nov 26, 2018
AlexeyBarabash added a commit that referenced this pull request Nov 26, 2018
@AlexeyBarabash
Copy link
Contributor Author

master bb9cf49
0.57.x 14116c5
0.58.x 6f216c2

petemill pushed a commit to petemill/brave-core that referenced this pull request Nov 27, 2018
@bbondy bbondy added this to the 0.57.x - Release milestone Jan 14, 2019
@bsclifton bsclifton deleted the sync_folder_custom_title branch January 24, 2019 21:29
hashmi-waseem pushed a commit to hashmi-waseem/brave-core that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Folder created on Android shows up without name
5 participants