PDF checks for blocking should use proper tab origin #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diracdeltas
reviewed
Nov 27, 2018
|
|
||
| GURL GetURLOrPDFURL(const GURL& url) { | ||
| if (url.SchemeIs("chrome-extension") && | ||
| url.host() == pdfjs_extension_id) { |
There was a problem hiding this comment.
[minor] it would be helpful to set chrome-extension://<pdfjs_extension_id>/ as a constant pdfjs_extension_prefix in extension_constants since it is repeated a lot in this PR and will also be needed in the PR to hide the pdfjs prefix.
then this check can be replaced with if (url.GetOrigin() == pdfjs_extension_prefix)
diracdeltas
reviewed
Nov 27, 2018
| @@ -23,7 +24,7 @@ void BraveRequestInfo::FillCTXFromRequest(const net::URLRequest* request, | |||
| std::shared_ptr<brave::BraveRequestInfo> ctx) { | |||
| ctx->request_identifier = request->identifier(); | |||
| ctx->request_url = request->url(); | |||
| ctx->tab_origin = request->site_for_cookies().GetOrigin(); | |||
| ctx->tab_origin = brave::GetURLOrPDFURL(request->site_for_cookies()).GetOrigin(); | |||
There was a problem hiding this comment.
is ctx->tab_origin used for anything security-related? if so it probably shouldn't be set to the pdfjs pseudo-origin.
There was a problem hiding this comment.
no only our internal filtering, but I'll update this to scope it to only adblock+TP or just exclude TP.
|
I'm going to change to different approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#1033
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: