No Bug: Add non breaking space for "Learn more" strings. (#2236)

brave · Jan 28, 2020 · cc7fee5 · cc7fee5
1 parent 79c920e
commit cc7fee5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/Client/Frontend/NTP/NTPNotificationViewController.swift b/Client/Frontend/NTP/NTPNotificationViewController.swift
@@ -77,9 +77,9 @@ class NTPNotificationViewController: TranslucentBottomSheet {
 
         switch state {
         case .getPaidTurnRewardsOn, .getPaidTurnAdsOn:
-            let learnMore = Strings.learnMore
+            let learnMore = Strings.learnMore.withNonBreakingSpace
             config.bodyText =
-                (text: "\(Strings.NTP.getPaidToSeeThisImage)\n\(learnMore)",
+                (text: "\(Strings.NTP.getPaidToSeeThisImage) \(learnMore)",
                     urlInfo: [learnMore: "learn-more"],
                     action: { [weak self] action in
                         self?.learnMoreHandler?()
@@ -100,10 +100,10 @@ class NTPNotificationViewController: TranslucentBottomSheet {
                     self?.close()
                 })
         case .gettingPaidAlready:
-            let learnMore = Strings.learnMore
+            let learnMore = Strings.learnMore.withNonBreakingSpace
 
             config.bodyText =
-                (text: "\(Strings.NTP.youArePaidToSeeThisImage)\n\(learnMore)",
+                (text: "\(Strings.NTP.youArePaidToSeeThisImage) \(learnMore)",
                     urlInfo: [learnMore: "learn-more"],
                     action: { [weak self] action in
                         self?.learnMoreHandler?()

diff --git a/Shared/Extensions/StringExtensions.swift b/Shared/Extensions/StringExtensions.swift
@@ -127,4 +127,8 @@ extension String {
         attributedString.addAttributes(boldFontAttribute, range: range)
         return attributedString
     }
+
+    public var withNonBreakingSpace: String {
+        self.replacingOccurrences(of: " ", with: "\u{00a0}")
+    }
 }