Feedback related with security

brave · Jul 15, 2021 · d60f963 · d60f963
1 parent 5b4f53a
commit d60f963
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/Client/Application/Delegates/AppDelegate.swift b/Client/Application/Delegates/AppDelegate.swift
@@ -635,7 +635,7 @@ extension AppDelegate {
                 if let userInfo = userActivity.userInfo,
                     let urlString = userInfo[CSSearchableItemActivityIdentifier] as? String,
                     let url = URL(string: urlString) {
-                    browserViewController.switchToTabForURLOrOpen(url, isPrivileged: true)
+                    browserViewController.switchToTabForURLOrOpen(url, isPrivileged: false)
                     return true
                 }
             case ActivityType.newTab.identifier:
@@ -677,7 +677,7 @@ extension AppDelegate {
                 return false
             }
 
-            browserViewController.switchToTabForURLOrOpen(url, isPrivileged: true)
+            browserViewController.switchToTabForURLOrOpen(url, isPrivileged: false)
             return true
         }
 

diff --git a/Client/Application/Shortcuts/ActivityShortcutManager.swift b/Client/Application/Shortcuts/ActivityShortcutManager.swift
@@ -192,6 +192,10 @@ class ActivityShortcutManager: NSObject {
     // MARK: Intent Donation Methods
 
     public func donateCustomIntent(for type: IntentType, with urlString: String) {
+        guard !PrivateBrowsingManager.shared.isPrivateBrowsing else {
+            return
+        }
+
         let intent = createCustomIntent(for: type, with: urlString)
 
         let interaction = INInteraction(intent: intent, response: nil)