SFController used instead of onboardingview controller

brave · Nov 8, 2022 · fed8f9e · fed8f9e
1 parent 76384ea
commit fed8f9e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/Client/Frontend/Browser/BrowserViewController/BrowserViewController+Callout.swift b/Client/Frontend/Browser/BrowserViewController/BrowserViewController+Callout.swift
@@ -11,6 +11,7 @@ import SwiftKeychainWrapper
 import SwiftUI
 import BraveVPN
 import Onboarding
+import SafariServices
 
 // MARK: - Callouts
 
@@ -53,7 +54,10 @@ extension BrowserViewController {
           self?.braveCore.p3aUtils.isP3AEnabled = isOn
         },
         linkAction: { url in
-//          onboardingP3ACalloutController.present(OnboardingWebViewController(url: .p3aDescription), animated: true, completion: nil)
+          let p3aLearnMoreController = SFSafariViewController(url: BraveUX.braveP3ALearnMoreURL, configuration: .init())
+          p3aLearnMoreController.modalPresentationStyle = .currentContext
+
+          onboardingP3ACalloutController.present(p3aLearnMoreController, animated: true)
         },
         primaryButtonAction: { [weak self] in
           Preferences.Onboarding.p3aOnboardingShown.value = true

diff --git a/Sources/Onboarding/Welcome/WelcomeViewController.swift b/Sources/Onboarding/Welcome/WelcomeViewController.swift
@@ -10,6 +10,7 @@ import BraveShared
 import Shared
 import BraveCore
 import BraveUI
+import SafariServices
 
 private enum WelcomeViewID: Int {
   case background = 1
@@ -368,7 +369,10 @@ public class WelcomeViewController: UIViewController {
           self?.p3aUtilities.isP3AEnabled = isOn
         },
         linkAction: { url in
-//          nextController.present(OnboardingWebViewController(url: .p3aDescription), animated: true, completion: nil)
+          let p3aLearnMoreController = SFSafariViewController(url: BraveUX.braveP3ALearnMoreURL, configuration: .init())
+          p3aLearnMoreController.modalPresentationStyle = .currentContext
+
+          nextController.present(p3aLearnMoreController, animated: true)
         },
 
         primaryButtonAction: { [weak self] in