Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add bookmarklet support #1119

Closed
andreiburov opened this issue Jun 3, 2019 · 4 comments · Fixed by #1385
Closed

Add bookmarklet support #1119

andreiburov opened this issue Jun 3, 2019 · 4 comments · Fixed by #1385

Comments

@andreiburov
Copy link

andreiburov commented Jun 3, 2019

Description:

Like mentioned in the previous repo, there is a need for the bookmarklet support https://github.com/brave/browser-ios/issues/1724. Thus feature is supported by both safari and firefox on ios.

@srirambv srirambv added priority/p5 Not scheduled. Don't anticipate work on this any time soon. suggestion labels Jun 4, 2019
@Brandon-T Brandon-T self-assigned this Aug 12, 2019
@iccub iccub added this to the 1.13 milestone Sep 26, 2019
@iccub iccub removed priority/p5 Not scheduled. Don't anticipate work on this any time soon. suggestion labels Sep 26, 2019
@srirambv
Copy link
Contributor

Verification passed on iPad Pro with iOS 13.2 running 1.13(19.10.16.18)

  • Verified bookmark can't be saved with just
javascript:function() {}
  • Verified bookmark can't be saved with just
javascript:
  • Verified bookmark is saved as below but doesn't show any error when loading
javascript:fun
  • Verified bookmark can be saved as below and an alert prompt is shown
javascript:(function(){ alert("hello"); })()

image

@srirambv
Copy link
Contributor

Verification passed on iPad Pro with iOS 12.4 running 1.13(19.10.16.18)

  • Verified bookmark can't be saved with just
javascript:function() {}
  • Verified bookmark can't be saved with just
javascript:
  • Verified bookmark is saved as below but doesn't show any error when loading
javascript:fun
  • Verified bookmark can be saved as below and an alert prompt is shown
javascript:(function(){ alert("hello"); })()

image

@srirambv
Copy link
Contributor

Verification passed on iPhone Xr with iOS 13.2 running 1.13(19.10.18.15)

  • Verified bookmark can't be saved with just
javascript:function() {}
  • Verified bookmark can't be saved with just
javascript:
  • Verified bookmark is saved as below but doesn't show any error when loading
javascript:fun
  • Verified bookmark can be saved as below and an alert prompt is shown
javascript:(function(){ alert("hello"); })()

image

Verification passed on iPhone 7+ with iOS 13.2 running 1.13(19.10.18.15)

  • Verified bookmark can't be saved with just
javascript:function() {}
  • Verified bookmark can't be saved with just
javascript:
  • Verified bookmark is saved as below but doesn't show any error when loading
javascript:fun
  • Verified bookmark can be saved as below and an alert prompt is shown
javascript:(function(){ alert("hello"); })()

image

Verification passed on iPhone 6 with iOS 12.4 running 1.13(19.10.18.15)

  • Verified bookmark can't be saved with just
javascript:function() {}
  • Verified bookmark can't be saved with just
javascript:
  • Verified bookmark is saved as below but doesn't show any error when loading
javascript:fun
  • Verified bookmark can be saved as below and an alert prompt is shown
javascript:(function(){ alert("hello"); })()

image

@micahjon
Copy link

Has anyone figured out how to install the Push to Kindle bookmarklet on Brave? Works fine in Safari, but evidently fails validation in Brave. Would be nice if there was some error message or something
https://www.fivefilters.org/push-to-kindle/push-to-kindle-bookmarklet/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.