Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Support Dark Mode #1493

Closed
jhreis opened this issue Sep 6, 2019 · 1 comment
Closed

Support Dark Mode #1493

jhreis opened this issue Sep 6, 2019 · 1 comment

Comments

@jhreis
Copy link
Contributor

jhreis commented Sep 6, 2019

Problem Description

Support dark mode!

Feature Overview

iOS 13 announced dark mode support, and we should support this.

Design

Implementation Details

User Experience

  • iOS 13 will auto-detect the OS theme, and be themed appropriately
  • Both iOS 12 and 13 will give users option between light/dark mode

QA Steps

  • Verify User Experience toggles / options are correct
  • General coloring throughout application. This touches most of the app

Additional information

🎉

@jhreis jhreis mentioned this issue Sep 6, 2019
@jhreis jhreis added this to the 1.12 milestone Sep 6, 2019
@jhreis jhreis closed this as completed in 45787a9 Sep 6, 2019
iccub pushed a commit that referenced this issue Sep 6, 2019
* Adjusted background color for back/forward menu.
* Updated the first onboarding screen per design QA.
@srirambv
Copy link
Contributor

srirambv commented Sep 11, 2019

Verification passed on iPhone XR with iOS 13.1 beta 2 running 1.12(19.09.11.15)

  • Verified clean install automatically chooses the system default theme for the browser
  • Verified on upgrade theme is set to default and uses system theme
  • Verified setting light theme on the browser when the device is on dark changes complete browser UI to the light theme
  • Verified setting dark theme on the browser when the device is on light changes complete browser UI to dark theme
  • Verified setting dark/light theme doesn't affect private browsing window
  • Verified changing theme from action centre immediately updates the browser UI to the current theme when its set to automatic
  • Verified changing theme from action centre doesn't update the browser UI to the current theme when its set to explicit light/dark

Verification PASSED on iPad Air 3rd Generation using iOS 13.1 running 1.12 (19.09.11.22):

  • Verified clean install automatically chooses the system default theme for the browser
  • Verified on upgrade theme is set to default and uses system theme
  • Verified setting light theme on the browser when the device is on dark changes complete browser UI to the light theme
  • Verified setting dark theme on the browser when the device is on light changes complete browser UI to dark theme
  • Verified setting dark/light theme doesn't affect private browsing window
  • Verified changing theme from action centre immediately updates the browser UI to the current theme when its set to automatic
  • Verified changing theme from action centre doesn't update the browser UI to the current theme when its set to explicit light/dark

Verification passed on iPhone 7+ with iOS 12.4.1 running 1.12(19.09.13.06)

  • Verified clean install automatically sets the light theme for the browser
  • Verified on upgrade theme is set to default and uses system theme(Light)
  • Verified updating theme in browser setting take effect immediately

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants