Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Crashes when attempting to clear private data on iPadOS 13.2 #1951

Closed
kylehickinson opened this issue Nov 13, 2019 · 1 comment
Closed

Crashes when attempting to clear private data on iPadOS 13.2 #1951

kylehickinson opened this issue Nov 13, 2019 · 1 comment
Assignees
@kylehickinson
Labels
bug crash Epic: Privacy iPad-specific QA Pass - iPad QA/Yes release-notes/include
Milestone
1.14

Comments

@kylehickinson
Copy link
Collaborator

Due to a regression in iOS 13.2 we must show all action sheets as popovers in iPad even when displayed compact width size classes

One missed action sheet was the clear private data action sheet.
@kylehickinson kylehickinson self-assigned this Nov 13, 2019
@kylehickinson kylehickinson added this to the 1.14 milestone Nov 13, 2019
kylehickinson added a commit that referenced this issue Nov 14, 2019
@kylehickinson
Fix #1951: Present action sheets as a popover on iPads to fix crashes
89005a2 
Starting in iOS 13.2 there is a regression which causes action sheets to require presentation as a popover even when being presented within view controllers which have compact width size classes. In previous iOS versions they would present as an over-current-context iPhone action sheet
kylehickinson added a commit that referenced this issue Nov 14, 2019
@kylehickinson
Fix #1951: Present action sheets as a popover on iPads to fix crashes
ef94d96 
Starting in iOS 13.2 there is a regression on iPads which causes action sheets to require presentation as a popover even when being presented within view controllers which have compact width size classes. In previous iOS versions they would present as an over-current-context iPhone action sheet
@kylehickinson kylehickinson mentioned this issue Nov 14, 2019
Merged
7 tasks
@iccub iccub closed this as completed in 6c431e7 Nov 14, 2019
This was referenced Nov 21, 2019
Closed
Closed
Closed
@srirambv
Copy link
Contributor

Verification passed on iPad Pro with 13.2 running 1.14(19.11.20.19)

  • Verified no crash when trying to clear browsing data
    image

  • Verified no crash when trying to remove sync device from chain
    image

  • Verified no crash when trying to remove excluded sites in rewards panel
    image

This was referenced Dec 3, 2019
Merged
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug crash Epic: Privacy iPad-specific QA Pass - iPad QA/Yes release-notes/include
Projects
None yet
Milestone
1.14
Development

No branches or pull requests
3 participants
@kylehickinson @iccub @srirambv