Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add sync device via codewords in Japanese lang missing description #1979

Closed
iccub opened this issue Nov 18, 2019 · 1 comment
Closed

Add sync device via codewords in Japanese lang missing description #1979

iccub opened this issue Nov 18, 2019 · 1 comment
Assignees
@iccub
Labels
bug Epic: Sync QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.14

Comments

@iccub
Copy link
Contributor

iccub commented Nov 18, 2019

Description:

Steps to Reproduce

  1. Set language to Japanese
  2. Try to add a new device using codewords

Actual result:

Zrzut ekranu 2019-11-18 o 18 38 55

Expected result:
Missing description

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@iccub iccub added this to the 1.14 milestone Nov 18, 2019
@iccub iccub self-assigned this Nov 18, 2019
iccub added a commit that referenced this issue Nov 19, 2019
@iccub
Fix #1501, fix #1979: Add device screen UI polish.
1a6279f 
- Add styling for segmented control on iOS13 devices.
- Make password comment text has red color
- Description in Japanese language was missing.

All attributed texts are now optional, if they fail a regular string
will be shown.
iccub added a commit that referenced this issue Nov 19, 2019
@iccub
Fix #1501, fix #1979: Add device screen UI polish.
c4889bf 
- Add styling for segmented control on iOS13 devices.
- Make password comment text has red color
- Description in Japanese language was missing.

All attributed texts are now optional, if they fail a regular string
will be shown.
@iccub iccub closed this as completed in 21f42e4 Nov 19, 2019
This was referenced Nov 21, 2019
Closed
Closed
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Nov 21, 2019 •
edited by srirambv
Loading

Verification PASSED on iPhone 6s running iOS 13.2.2 using 1.14 (19.11.20.19)

IMG_0029

Verification PASSED on iPhone 6s+ running iOS 12.4.1 using 1.14 (19.11.20.19)

IMG_9934

Verification PASSED on iPad Air 3rd Gen running iOS 13.3 using 1.14 (19.11.20.19)

IMG_A70E59915CC6-1

Verification PASSED on iPad Mini 4 running iOS 12.4.1 using 1.14 (19.11.20.19)

IMG_F062AAA118B3-1

Verification passed on iPhone XR with iOS 13.2 running 1.14(19.11.27.22)
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
bug Epic: Sync QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.14
Development

No branches or pull requests
3 participants
@kjozwiak @iccub @srirambv