Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

NTP Branded Backgrounds #2151

Closed
15 tasks done
jhreis opened this issue Jan 7, 2020 · 0 comments
Closed
15 tasks done

NTP Branded Backgrounds #2151

jhreis opened this issue Jan 7, 2020 · 0 comments
Assignees
@jhreis
Labels
enhancement Epic: NTP QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.14.3

Comments

@jhreis
Copy link
Contributor

jhreis commented Jan 7, 2020 •
edited by iccub
Loading

Description:

Branded NTP should be supported. This includes a lot of smaller tweaks as well:

  • Add image credit to the collection view so it does not cover favorites.
  • Landscape redesign
  • Remove background long-press
  • Remove sponsored background tap
  • Disable vertical bouncing
  • Landscape centering

Branded behavior:

  • Re-enabling (or disabling) background images should automatically re-enable (or disable) branded images.
  • When disabling Background Images in settings, all favorites and frequently visited sites are displayed as per pre-NTP background image.
  • No NTP branded images to be shown in private mode.
  • Fix pre-defined rotation of branded images (1 in 4)
  • Show branded image as second image
  • Pre-defined rotation of branded images
  • Brand overlay
  • Clicking brand → website
  • All rewards popups
@jhreis jhreis added this to the 1.15 milestone Jan 7, 2020
iccub pushed a commit that referenced this issue Jan 17, 2020
@jhreis @iccub
Ref #2151: split favorites section on iPads and iPhones in landscape
3108d66
@jhreis jhreis modified the milestones: 1.15, 1.14.3 Jan 22, 2020
@iccub iccub mentioned this issue Jan 22, 2020
Merged
7 tasks
jhreis pushed a commit that referenced this issue Jan 22, 2020
@iccub @jhreis
Ref #2151 New tab page notifications (#2214)
1a4afab
jhreis pushed a commit that referenced this issue Jan 22, 2020
@iccub @jhreis
Ref #2151 New tab page notifications (#2214)
4d05c70
iccub added a commit that referenced this issue Jan 23, 2020
@iccub
Ref #2151: At least one notification must show before we lock showing…
46a90ac 
… subsequent notifications.
iccub added a commit that referenced this issue Jan 23, 2020
@iccub
Ref #2151: At least one notification must show before we lock showing…
9a31443 
… subsequent notifications.
iccub added a commit that referenced this issue Jan 23, 2020
@iccub
Ref #2151: At least one notification must show before we lock showing…
232934b 
… subsequent notifications.
jhreis pushed a commit that referenced this issue Jan 23, 2020
@iccub @jhreis
Ref #2151: At least one notification must show before we lock showing…
78f7195 
… subsequent notifications. (#2228)
This was referenced Jan 27, 2020
Closed
Merged
@iccub iccub closed this as completed in 8a1db95 Jan 28, 2020
jhreis pushed a commit that referenced this issue Jan 28, 2020
@iccub @jhreis
Ref #2151: At least one notification must show before we lock showing…
8a31842 
… subsequent notifications. (#2228)
jhreis added a commit that referenced this issue Jan 28, 2020
@jhreis
Fix #2151, Fix #2083: Branded background images (#2203)
78e7495
jhreis added a commit that referenced this issue Jan 28, 2020
@jhreis
Ref #2151: split favorites section on iPads and iPhones in landscape
14186df
This was referenced Jan 28, 2020
Closed
Closed
Closed
@iccub iccub mentioned this issue Feb 11, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jhreis jhreis

Labels
enhancement Epic: NTP QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.14.3
Development

No branches or pull requests
4 participants
@kjozwiak @jhreis @iccub @srirambv