Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

entire a-c not going through due to missing delays #2200

Closed
kjozwiak opened this issue Jan 14, 2020 · 5 comments · Fixed by #2389
Closed

entire a-c not going through due to missing delays #2200

kjozwiak opened this issue Jan 14, 2020 · 5 comments · Fixed by #2389
Assignees
@kylehickinson
Labels
bug Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.15.1

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Jan 14, 2020 •
edited
Loading

Placeholder for brave/brave-browser#7709 which also needs to be fixed on iOS as all current platforms are affected. Quick summary of issue:

When going through an a-c, the entire amount doesn't go through when you have multiple entries in the a-c table due to missing delays

Created issues for iOS & Android:

CCing @NejcZdovc @jhreis @anthonypkeane @srirambv
@kjozwiak kjozwiak mentioned this issue Jan 14, 2020
Closed
@kylehickinson kylehickinson added the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Jan 14, 2020
@kylehickinson
Copy link
Collaborator

Requires DB migration to get the fix from brave-core

@kjozwiak
Copy link
Member Author

@NejcZdovc re: the database migration, is that referring to brave/brave-core#4252 which you're currently working on?

@NejcZdovc
Copy link

@kjozwiak yes

@kylehickinson
Copy link
Collaborator

Will be fixed with #2378

@kylehickinson kylehickinson linked a pull request Mar 4, 2020 that will close this issue
Fix #2378: iOS DB Migration & Rebase to brave-core master #2389
Merged
7 tasks
@kylehickinson kylehickinson mentioned this issue Mar 4, 2020
Merged
7 tasks
@NejcZdovc NejcZdovc removed the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Mar 11, 2020
@jhreis jhreis added this to the 1.15.1 milestone Mar 11, 2020
@NejcZdovc NejcZdovc mentioned this issue Mar 13, 2020
Closed
This was referenced Mar 18, 2020
Closed
Closed
Closed
@srirambv
Copy link
Contributor

Verification passed on iPhone XR/iPhone 7+/iPhone SE/iPad Pro (iOS 12)/iPad Pro (iOS 13).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.15.1
Development

Successfully merging a pull request may close this issue.

Fix #2378: iOS DB Migration & Rebase to brave-core master brave/brave-ios
5 participants
@kylehickinson @kjozwiak @jhreis @NejcZdovc @srirambv