entire a-c not going through due to missing delays #7709

kjozwiak · 2020-01-13T08:02:53Z

Description

The entire a-c amount not going through because it's being blocked server side due to missing delays.

Example:

received 2.5 BAT from ad grant
received 17.5 BAT from UGP grant
Total BAT: 20 BAT
a-c setup as Up to 15 BAT via brave://settings

Only 8 BAT went through rather than the 15 BAT

Created issues for iOS & Android:

Steps to Reproduce

Case #1

launch Brave using --enable-logging=stderr --rewards=staging=true,reconcile-interval=5
set Monthly Payment to 10 BAT (should be already selected as the default)
accept the UGP grant
spend ~1.5mins on https://duckduckgo.com/ and ensure it's being displayed in the a-c table
spend ~1.5mins on https://laurenwags.github.io/ and ensure it's being displayed in the a-c table
spend ~1.5mins on https://yachtcaptain23.github.io and ensure it's being displayed in the a-c table
ensure that a-c goes through and the correct amount is deducted from the total
ensured that the correct amount of BAT has been deducted from Brave

Case #2

entire a-c not going through due to missing delays #7709 (comment)

Actual result:

`Using UGP without any ad grants:`

Expected result:

If the user has the required funds, the entire a-c should go through.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave	1.5.27 Chromium: 79.0.3945.117 (Official Build) nightly (64-bit)
Revision	04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS	macOS Version 10.15.2 (Build 19C57

Brave	1.3.89 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision	04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS	macOS Version 10.15.2 (Build 19C57)

Version/Channel Information:

Can you reproduce this issue with the current release? Couldn't reproduce with 1.2.42 CR: 79.0.3945.117
Can you reproduce this issue with the beta channel? Yes
Can you reproduce this issue with the dev channel? Yes
Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? N/A
Does the issue resolve itself when disabling Brave Rewards? N/A
Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @brave/legacy_qa @evq @NejcZdovc @rebron @mandar-brave

The text was updated successfully, but these errors were encountered:

kjozwiak · 2020-01-13T08:05:45Z

Labeling as release/blocking for now till @evq and @NejcZdovc investigate.

LaurenWags · 2020-01-13T17:51:09Z

This should also be checked in with a monthly tip (monthly contribution) - so have a monthly tip set up along with AC. So something like:

launch Brave using --enable-logging=stderr --rewards=staging=true,reconcile-interval=5
set Monthly Payment to 10 BAT (should be already selected as the default)
accept the UGP grant
set up a monthly tip for a site like 3zsistemi.si, confirm it is shown on Monthly Contributions panel on brave://rewards
spend ~1min on https://duckduckgo.com/ and ensure it's being displayed in the a-c table
spend ~1min on https://laurenwags.github.io/ and ensure it's being displayed in the a-c table
spend ~1min on https://yachtcaptain23.github.io and ensure it's being displayed in the a-c table
ensure monthly tip goes thru and correct amount is deducted from the total
ensure that a-c goes through and the correct amount is deducted from the total

LaurenWags · 2020-01-14T14:54:22Z

@GeetaSarvadnya also ran into the following scenario, which sounds related to this issue and should be retested once this issue is resolved:

Clean profile with 1.2.x, launch with staging parameters & quick reconcile
Set up data for AC, but before AC occurs upgrade to 1.3.x
--> After upgrade AC is not occurring but wallet balance is being reduced

@GeetaSarvadnya please update this scenario with any additional relevant details so we can retest once this issue is resolved 👍

GeetaSarvadnya · 2020-01-14T15:17:39Z

AC and monthly Tip values are not reflected in Panel/Summary/NTP widget after the auto contribution

Case 1:

Clean profile 1.2.39 - launch brave with staging flag and with reconcile interval
Claim UGP grants
Set monthly Tip for https://duckduckgo.com/
Send a one-time tip to https://duckduckgo.com/
Before the auto contribution upgrade profile to 1.3.91
Wait until auto contribution completes

Actual:

AC is going through and correct balance is getting deducted but it's not shown in panel or summary or NTP widget
Monthly tip is processing and the correct amount is deducted but the monthly tip isn't shown in panel or summary or NTP widget
There is no AC notification
AC table is getting cleared only after brave://rewards page reload

Case 2:

Clean profile 0.71.104 launch brave with staging flag with short reconcile interval
Claim UGP grants
Set monthly Tip for https://duckduckgo.com/
Send a one-time tip to https://duckduckgo.com/
Trigger auto contribution and ensured AC amount is reflected in panel and summary
Upgrade 1.3.91
Add https://duckduckgo.com/ to auto contribution table
Trigger auto contribution

Actual:

AC is going through and correct balance is getting deducted but it's not shown in panel or summary or NTP widget
Monthly tip is processing and the correct amount is deducted but the monthly tip isn't shown in panel or summary or NTP widget
There is no AC notification

LaurenWags · 2020-01-14T15:40:38Z

reproduced #7709 (comment) on macOS

Brave	1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision	04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS	macOS Version 10.14.6 (Build 18G103)

@NejcZdovc will the fix for this issue also address @GeetaSarvadnya finding that the summary (panel and on brave://rewards) is not reflecting the Auto-Contribute and Monthly Contribution amounts? For example, in the below image, the AC and Monthly Contribution amounts were from 1.2.39. When I upgraded to 1.3.91 and AC occurred again, the AC and Monthly Contribution amounts should have increased (5--> 10 and 1--> 2), however they did not.

Please let us know if this should be logged separately.

cc @kjozwiak

NejcZdovc · 2020-01-14T15:43:26Z

@LaurenWags if I understand correctly just UI is not updated, but everything else works as expected?

NejcZdovc · 2020-01-14T15:44:53Z

could be this issue #7526?

LaurenWags · 2020-01-14T15:52:27Z

I think so. will add comment on that issue as well. thanks @NejcZdovc !

Resolves brave/brave-browser#7709 Resolves brave/brave-browser#6940

GeetaSarvadnya · 2020-01-20T07:14:30Z

One-time tips are not shown in the Tips panel.

Case 1: #7608 (comment)

Case 2: Please note this case is intermittent but 80% is a reproducible rate

Clean profile 1.3.94 - launch Brave using --enable-logging=stderr --rewards=staging=true
Restore Ads grants
Claim Ads grants
Claim UGP grants
Open https://duckduckgo.com/
Send a one-time tip of 1 BAT to DDG
One-time is not displayed under Tips panel, Tips panel is empty, reload brave://rewards multiple times didn't help

Resolves brave/brave-browser#7709 Resolves brave/brave-browser#6940

LaurenWags · 2020-02-03T21:03:00Z

Verified passed with

Brave	1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	macOS Version 10.14.6 (Build 18G103)

Verified test plans from Adds delays for suggestion api brave-core#4372
Test Plan 1:

Test Plan 2:

Verified Case 1 from description:

Verified Case 2 from description:

Verified example from description:

Additional testing notes can be found here:

Verification passed on

Brave	1.3.109 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

Verified the test plan from
Plan 1:

Plan 2:
Logged #8041

Verified Case 1 from the description
Verified Case 2 from description
Encountered Folllow up of #7526 - Unable to set monthly tips hence not shown under contribution panel #8019
Verified the cases from entire a-c not going through due to missing delays #7709 (comment)

Verification passed on

Brave	1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision	cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS	Ubuntu 18.04 LTS

Verified test plans from Adds delays for suggestion api brave-core#4372
Test Plan 1:

Test Plan 2:

Also verified test plan from the description.

kjozwiak added bug release/blocking feature/rewards QA/Yes QA/Test-Plan-Specified labels Jan 13, 2020

kjozwiak added this to the 1.3.x - Beta milestone Jan 13, 2020

NejcZdovc self-assigned this Jan 13, 2020

kjozwiak mentioned this issue Jan 13, 2020

Fixes contribution with unblinded tokens brave/brave-core#4317

Merged

32 tasks

LaurenWags mentioned this issue Jan 14, 2020

Monthly contributions (tips) and Auto Contribute are not listed on brave://rewards or panel summary #7526

Closed

btlechowski mentioned this issue Jan 14, 2020

Rewards NTP widget is not reflecting AC #6740

Closed

NejcZdovc mentioned this issue Jan 14, 2020

Adds delays for suggestion api brave/brave-core#4372

Merged

32 tasks

kjozwiak mentioned this issue Jan 14, 2020

entire a-c not going through due to missing delays brave/brave-ios#2200

Closed

NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 16, 2020

Adds delays for suggestion api

0156052

Resolves brave/brave-browser#7709 Resolves brave/brave-browser#6940

kjozwiak mentioned this issue Jan 20, 2020

tips not going thru when tokens are not standardized to 0.25 value #7608

Closed

NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 20, 2020

Adds delays for suggestion api

111c264

Resolves brave/brave-browser#7709 Resolves brave/brave-browser#6940

NejcZdovc added the QA/Blocked label Jan 21, 2020

LaurenWags added the release-notes/exclude label Jan 22, 2020

NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 22, 2020

Adds delays for suggestion api

2ee5944

Resolves brave/brave-browser#7709 Resolves brave/brave-browser#6940

bsclifton closed this as completed in brave/brave-core#4372 Jan 22, 2020

LaurenWags mentioned this issue Jan 27, 2020

Grant virtualization - Phase 1 #6078

Closed

This was referenced Jan 27, 2020

Adds delays for suggestion api (uplift to 1.4) brave/brave-core#4436

Merged

WIP: Adds delays for suggestion api (uplift to 1.3) brave/brave-core#4441

Closed

Adds delays for suggestion api (uplift to 1.3) brave/brave-core#4448

Merged

LaurenWags removed the QA/Blocked label Jan 30, 2020

LaurenWags added the QA Pass-macOS label Feb 3, 2020

GeetaSarvadnya added the QA Pass-Win64 label Feb 4, 2020

kjozwiak mentioned this issue Feb 4, 2020

Manual test run on Linux for 1.3.x - Release #8052

Closed

btlechowski added the QA Pass-Linux label Feb 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

entire a-c not going through due to missing delays #7709

entire a-c not going through due to missing delays #7709

kjozwiak commented Jan 13, 2020 •

edited

Loading

kjozwiak commented Jan 13, 2020

LaurenWags commented Jan 13, 2020 •

edited

Loading

LaurenWags commented Jan 14, 2020

GeetaSarvadnya commented Jan 14, 2020 •

edited

Loading

LaurenWags commented Jan 14, 2020

NejcZdovc commented Jan 14, 2020

NejcZdovc commented Jan 14, 2020

LaurenWags commented Jan 14, 2020

GeetaSarvadnya commented Jan 20, 2020 •

edited

Loading

LaurenWags commented Feb 3, 2020 •

edited by btlechowski

Loading

entire a-c not going through due to missing delays #7709

entire a-c not going through due to missing delays #7709

Comments

kjozwiak commented Jan 13, 2020 • edited Loading

Description

Steps to Reproduce

Actual result:

Using UGP without any ad grants:

Using UGP without any ad grants:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

kjozwiak commented Jan 13, 2020

LaurenWags commented Jan 13, 2020 • edited Loading

LaurenWags commented Jan 14, 2020

GeetaSarvadnya commented Jan 14, 2020 • edited Loading

LaurenWags commented Jan 14, 2020

NejcZdovc commented Jan 14, 2020

NejcZdovc commented Jan 14, 2020

LaurenWags commented Jan 14, 2020

GeetaSarvadnya commented Jan 20, 2020 • edited Loading

LaurenWags commented Feb 3, 2020 • edited by btlechowski Loading

kjozwiak commented Jan 13, 2020 •

edited

Loading

`Using UGP without any ad grants:`

`Using UGP without any ad grants:`

LaurenWags commented Jan 13, 2020 •

edited

Loading

GeetaSarvadnya commented Jan 14, 2020 •

edited

Loading

GeetaSarvadnya commented Jan 20, 2020 •

edited

Loading

LaurenWags commented Feb 3, 2020 •

edited by btlechowski

Loading