Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

update wording on AC switch in AC settings #2402

Closed
LaurenWags opened this issue Mar 9, 2020 · 1 comment · Fixed by #2410
Closed

update wording on AC switch in AC settings #2402

LaurenWags opened this issue Mar 9, 2020 · 1 comment · Fixed by #2410
Assignees
@kylehickinson
Labels
desktop-parity enhancement Epic: Rewards QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.16

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Mar 9, 2020 •
edited
Loading

Description:

Wording for one of the switches in AC settings was updated on desktop with brave/brave-browser#6483 - see Item 3 on this issue

We probably want the same wording on iOS for consistency.

Steps to Reproduce

  1. Enable BR
  2. Open AC settings
  3. Locate switches

Actual result:
Switch says: Allow contribution to non-verified sites
IMG_0A7B36941203-1

Expected result:
We probably should have this say what it does on desktop which is : Show non-verified sites in list
Screen Shot 2020-03-09 at 5 21 47 PM

Reproduces how often: [Easily reproduced, Intermittent Issue]
easily

Brave Version:
1.15

Device details:
iPad 5th Gen iOS12

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@kylehickinson kylehickinson self-assigned this Mar 17, 2020
kylehickinson added a commit that referenced this issue Mar 17, 2020
@kylehickinson
Fix #2402: Update copy for Auto-Contribute settings to match desktop
326f37c
@kylehickinson kylehickinson mentioned this issue Mar 17, 2020
Merged
7 tasks
@kylehickinson kylehickinson added this to the 1.16 milestone Mar 24, 2020
kylehickinson added a commit that referenced this issue Mar 24, 2020
@kylehickinson
Fix #2402: Update copy for Auto-Contribute settings to match desktop (#…
fdd6a1e 
…2410)
@LaurenWags
Copy link
Member Author

LaurenWags commented May 5, 2020 •
edited by kjozwiak
Loading

Verification passed on iPad 5th Gen with iOS 12 running 1.16 (20.05.05.12)

  • Verified STR from description
    iOS12iPad

Verification passed on iPad mini with iOS 13 running 1.16 (20.05.05.12)

  • Verified STR from description
    iOS13iPad

Verification PASSED on iPhone 11 iOS 13.4.1 & iPhone 6s+ iOS 12.4.1 using the following build:

1.16 (20.05.04.12)
iPhone 11 iOS 13.4.1 iPhone 6s+ iOS 12.4.1
IMG_0064 IMG_0017

@srirambv srirambv mentioned this issue May 8, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
desktop-parity enhancement Epic: Rewards QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.16
Development

Successfully merging a pull request may close this issue.

Fix #2402: Update copy for Auto-Contribute settings to match desktop brave/brave-ios
4 participants
@kylehickinson @kjozwiak @srirambv @LaurenWags