SI modal is retained when SI setting is disabled

[srirambv]

Description:

SI modal is retained when SI setting is disabled

Steps to Reproduce

1. Install 1.16(20.05.05.20)
2. Open a tab with SI
3. Disable Background images from settings, modal is retained

Actual result:

Expected result:
Modal should also be removed immediately when background images are removed

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.16

Device details:
All

Website problems only:

• did you check with Brave Shields down?
• did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

Follow up to #2500

[srirambv]

This happens even with CHP as well

[srirambv]

Verification passed on iPhone XR with iOS 13.5 running 1.18(20.06.09.18)

• Verified steps from issue description
• Verified no SI modal is retained when background images are disabled when shown

---

Verification passed on iPhone 7+ with iOS 13.5.1 running 1.18(20.06.26.17)

• Verified steps from issue description
• Verified no SI modal is retained when background images are disabled

---

Verification passed on iPhone 6 with iOS 12.4.7 running 1.18(20.06.26.17)

• Verified steps from issue description
• Verified no SI modal is retained when background images are disabled

---

Verification passed on iPad Pro with iOS 13.6 running 1.18(20.06.26.17)

• Verified steps from issue description
• Verified no SI modal is retained when background images are disabled

---

Verification passed on iPad Pro with iOS 12.4.5 running 1.18(20.06.26.17)

• Verified steps from issue description
• Verified no SI modal is retained when background images are disabled

---