Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Update feed when Today publishers are changed #3033

Closed
kylehickinson opened this issue Nov 12, 2020 · 2 comments · Fixed by #3208
Closed

Update feed when Today publishers are changed #3033

kylehickinson opened this issue Nov 12, 2020 · 2 comments · Fixed by #3208
Assignees
@kylehickinson
Labels
enhancement Epic: Brave News QA/Blocked QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.24

Comments

@kylehickinson
Copy link
Collaborator

Description:

When a user changes what publishers are enabled/disabled we should regenerate the cards for NEW new tab pages. Any NTP that is already open should use the old generated cards until a user either closes said NTP and opens a new one or taps the "New Content Available" button that will appear on top in those old NTPs.
@kylehickinson kylehickinson self-assigned this Jan 18, 2021
@kylehickinson kylehickinson added this to the 1.24 milestone Jan 18, 2021
kylehickinson added a commit that referenced this issue Jan 18, 2021
@kylehickinson
Fix #3033: Reload cards when Today publishers are changed
80744d8
@kylehickinson kylehickinson mentioned this issue Jan 18, 2021
Merged
7 tasks
kylehickinson added a commit that referenced this issue Jan 19, 2021
@kylehickinson
Fix #3033: Reload cards when Today publishers are changed (#3208)
4a76288
iccub added a commit that referenced this issue Jan 26, 2021
@iccub
Revert "Fix #3033: Reload cards when Today publishers are changed (#3208
b725358 
)"

This reverts commit 4a76288.
@srirambv
Copy link
Contributor

Verification passed on iPhone 7+ with iOS 14.4 running 1.24(21.3.15.18)

Verification passed on iPhone XR with iOS 14.4 running 1.24(21.3.15.18)

@srirambv
Copy link
Contributor

QA blocked on iOS 12 due to #3424

@srirambv srirambv mentioned this issue Mar 29, 2021
Closed
95 tasks
@kjozwiak kjozwiak mentioned this issue Apr 12, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
enhancement Epic: Brave News QA/Blocked QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.24
Development

Successfully merging a pull request may close this issue.

Fix #3033: Reload cards when Today publishers are changed brave/brave-ios
3 participants
@kylehickinson @kjozwiak @srirambv