Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

URL autocompletion doesn't suggest bookmarks anymore #3034

Closed
iccub opened this issue Nov 12, 2020 · 2 comments · Fixed by #3043
Closed

URL autocompletion doesn't suggest bookmarks anymore #3034

iccub opened this issue Nov 12, 2020 · 2 comments · Fixed by #3043
Assignees
@Brandon-T
Labels
bug Epic: Bookmarks/Favourites QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes regression release-notes/include
Milestone
1.22

Comments

@iccub
Copy link
Contributor

iccub commented Nov 12, 2020

Regression caused by moving over to the new sync implementation, and having to use new bookmarks model
@iccub iccub added this to the 1.22 milestone Nov 12, 2020
@Brandon-T Brandon-T self-assigned this Nov 13, 2020
@Brandon-T Brandon-T mentioned this issue Nov 17, 2020
Merged
7 tasks
@iccub
Copy link
Contributor Author

iccub commented Nov 19, 2020 •
edited
Loading

Test plan:

  • Install 1.22 build
  • Add few bookmarks, add few folders
  • Tap on url bar, start typing name of one of bookmarks you added
  • Verify that the bookmark shows in url suggestions
  • Start typing a name of folder you added
  • Verify that the folder does not show up in url suggestions

iccub pushed a commit that referenced this issue Nov 20, 2020
@Brandon-T
Fix #3034, #3032, #3045 - Bookmarks performance and UX fixes. (#3043)
d347372
iccub pushed a commit that referenced this issue Nov 20, 2020
@Brandon-T @iccub
Fix #3034, #3032, #3045 - Bookmarks performance and UX fixes. (#3043)
9b966bc
@srirambv
Copy link
Contributor

Verification passed on iPhone 7+ with iOS 14.2 running 1.22(20.11.20.16)

Verification passed on iPhone XR with iOS 13.5 running 1.22(20.11.20.16)

Verification passed on iPad Pro with iOS 12.4.1 running 1.22(20.11.20.16)

@kjozwiak kjozwiak changed the title Url autocompletion doesn't suggest bookmarks anymore URL autocompletion doesn't suggest bookmarks anymore Dec 11, 2020
@kjozwiak kjozwiak mentioned this issue Dec 11, 2020
Closed
@bsclifton bsclifton mentioned this issue Dec 11, 2020
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brandon-T Brandon-T

Labels
bug Epic: Bookmarks/Favourites QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes regression release-notes/include
Projects
None yet
Milestone
1.22
3 participants
@Brandon-T @iccub @srirambv