Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Improve bookmark scrolling when there is an insane amount of bookmarks #3071

Closed
srirambv opened this issue Nov 24, 2020 · 1 comment · Fixed by #3090
Closed

Improve bookmark scrolling when there is an insane amount of bookmarks #3071

srirambv opened this issue Nov 24, 2020 · 1 comment · Fixed by #3090
Assignees
@iccub
Labels
enhancement Epic: Bookmarks/Favourites QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.23

Comments

@srirambv
Copy link
Contributor

Description:

Improve bookmark scrolling when there is an insane amount of bookmarks

Steps to Reproduce

  1. Have a lot of bookmarks I mean really lot
  2. Open bookmarks menu and scroll through them
  3. There is a visible lag when trying to scroll through

Actual result:
Lag when scrolling through a lot of bookmarks

Expected result:
Smooth scrolling

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.22(20.11.20.16)

Device details:
All

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information
@srirambv srirambv added this to the 1.23 milestone Nov 24, 2020
@iccub iccub self-assigned this Nov 25, 2020
iccub added a commit that referenced this issue Nov 27, 2020
@iccub
Fix #3071: Load favicons on background thread, fix cell reusing.
ad57df9
iccub added a commit that referenced this issue Nov 27, 2020
@iccub
Fix #3071: Load favicons on background thread, fix cell reusing.
87bdff5
iccub added a commit that referenced this issue Nov 27, 2020
@iccub
Fix #3071: Load favicons on background thread, fix cell reusing.
8ed27d1
@iccub iccub mentioned this issue Nov 27, 2020
Merged
7 tasks
iccub added a commit that referenced this issue Nov 30, 2020
@iccub
Fix #3071: Load favicons on background thread, fix cell reusing.
155eaba
iccub added a commit that referenced this issue Nov 30, 2020
@iccub
Fix #3071: Load favicons on background thread, fix cell reusing.
40460e0
iccub added a commit that referenced this issue Dec 1, 2020
@iccub
Ref #3071: Don't use FaviconMO in fetchIcon method. Move it outside.
5e7d0fe
@iccub iccub mentioned this issue Dec 1, 2020
Merged
7 tasks
iccub added a commit that referenced this issue Dec 1, 2020
@iccub
Ref #3071: Don't use FaviconMO in fetchIcon method. Move it outsi…
67eeb0d 
…de. (#3096)
@srirambv srirambv mentioned this issue Feb 12, 2021
Open
@srirambv
Copy link
Contributor Author

Verification passed on iPhone XR with iOS 13.5 running 1.23(21.2.12.5)

  • Verified bookmarks scrolling is better than before

Verification passed on iPhone 7+with iOS 14.4running 1.23(21.2.12.5)

  • Verified bookmarks scrolling is better than before

Verification passed on iPad Pro with iOS 12.4.1running 1.23(21.2.12.5)

  • Verified bookmarks scrolling is better than before

Logged follow-up issue #3305

@kjozwiak kjozwiak mentioned this issue Feb 22, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
enhancement Epic: Bookmarks/Favourites QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.23
Development

Successfully merging a pull request may close this issue.

Fix #3071: Load favicons on background thread, fix cell reusing. brave/brave-ios
2 participants
@iccub @srirambv