Persist Private Tabs on Exit

[anthonypkeane]

Description:

Context: https://twitter.com/Legen_darium/status/1347605629712666631?s=20

Provide an option to keep private tabs when the user exits the browser.

The default will be off in that the current behavior is retained, but a user can change this should they wish.

Suggested Location

Brave Shields & Privacy
under block dangerous sites

add

Retain Private tabs on exit (On/Off toggle). - default off

@jamesmudgett to review before dev work begins.

[ttang4299]

Hi @iccub , any updates on this? I remember you mentioned that this feature would come next after tab sync, and I noticed tab sync being added a few updates back.

[iccub]

Yes @ttang4299, so we've hit some roadblocks, especially when it comes to having multiple windows with private mode or private-only-browsing mode. The rewrite is bigger than expected, at the moment there's no clear timeline for it.
Maybe I will try to push for a more simplified version without perfect handling of private modes

[notDavid]

Note that currently Private Tabs are also cleared when temporarily switching to the "non-private tabs" and then back to "private" tabs. Very annoying... 😊

Also, they are cleared at random, when switching between apps, or the app is updated i think.

PS. The Tweet/context no longer exists i think.

[mailinglists35]

Also, they are cleared at random, when switching between apps

I also noticed this as well when switching apps.
Despite having set "clear tabs after one month", many times (under iOS memory pressure I presume?) all tabs get discarded. Config set to private browsing only.

But maybe this should be it's own issue?

[iccub]

Private browsing always clear data when the app is killed or if the device is out of memory.
We work on making them persistent and let the user choose their behavior

[iccub]

Fixed in #7575

[Uni-verse]

Verified on iPhone per #7855 (comment)