Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Favicon Fallback Not Working #528

Closed
LaurenWags opened this issue Nov 30, 2018 · 2 comments · Fixed by #2490
Closed

Favicon Fallback Not Working #528

LaurenWags opened this issue Nov 30, 2018 · 2 comments · Fixed by #2490

Comments

@LaurenWags
Copy link
Member

Description:

It doesn't seem as though the fuzzy favicon fallback (https://github.com/brave/browser-ios/issues/1551) is working in 1.7 (if it's implemented).

Steps to Reproduce

  1. Clean install of 1.7
  2. Visit huffingtonpost.com
  3. Add to bookmarks and add to Favorites on new tab.
  4. Visit kpwags.com.
  5. Add to bookmarks and add to Favorites on new tab.

Actual result:
Favicon for huffpo doesn't have an icon or a letter, favicon for kpwags is fuzzy.
img_0246
img_0245

Expected result:
I'd expect both favicons to have letters since that's how they displayed in 1.6:
img_0247
img_0248

Reproduces how often: [Easily reproduced, Intermittent Issue]
easily

Brave Version:
1.7 (18.11.30.3)

Device details:
iPad iOS12

Website problems only:

  • did you check with Brave Shields down? n/a
  • did you check in Safari/Firefox (WkWebView-based browsers)? n/a

Additional Information

@vinasound2
Copy link

Hi everybody.
I have a website with wordpress source code with flatsome theme purchased on themeforest.
I have a very good website setup but there is a bug with favicon on the website.
I do not know why my website only shows favicon in the admin page and the others are not.
This is link : https://vinasound.vn/muc-san-pham/micro-thu-am

@jhreis jhreis changed the title favicon issues Favicon Fallback Not Working Jan 4, 2019
@kylehickinson kylehickinson linked a pull request May 26, 2020 that will close this issue
7 tasks
@kylehickinson kylehickinson added this to the 1.18 milestone Jun 3, 2020
@kylehickinson kylehickinson self-assigned this Jun 3, 2020
@srirambv
Copy link
Contributor

srirambv commented Jun 10, 2020

Verification passed on iPhone XR with iOS 13.5 running 1.18(20.06.09.18)


Verification passed on iPhone 7+ with iOS 13.4.5 running 1.18(20.06.16.08)

  • Verified steps from issue description
  • Verified fallback letters are shown for favourites
  • Verified bookmarks use low res icons when fallback icons are not available

Verification passed on iPad Pro with iOS 12.4.5 running 1.18(20.06.16.08)

  • Verified steps from issue description
  • Verified fallback letters are shown for favourites
    image
  • Verified bookmarks use low res icons when fallback icons are not available
    image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants