Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Wallet pending transactions not refreshed on network change #5770

Closed
StephenHeaps opened this issue Aug 2, 2022 · 0 comments · Fixed by #5771
Closed

Wallet pending transactions not refreshed on network change #5770

StephenHeaps opened this issue Aug 2, 2022 · 0 comments · Fixed by #5771
Assignees
Milestone

Comments

@StephenHeaps
Copy link
Contributor

Description:

Pending transactions are not refreshed when switching networks, so pending transactions for the old network may be shown with incorrect / unavailable transaction details shown in UI.

Steps to Reproduce

Don't close the wallet modal during this flow:

  1. Switch to Solana Devnet
  2. Create a transaction on Solana Devnet
  3. Don't approve/reject the transaction, dismiss the modal
  4. Switch to Solana Testnet
  5. Tap pending transactions button
  6. Observe incorrect transaction details shown

Actual result:

pending.transactions.bug.mov

Expected result:

Transaction is not shown as a pending transaction because it belongs to a different network for the same coin type.

Reproduces how often:

Easily reproduced

Brave Version:

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

Showing pending transactions for all networks on all supported coin types is not yet supported, see brave/brave-browser#24382

@StephenHeaps StephenHeaps added this to the 1.42 milestone Aug 2, 2022
@StephenHeaps StephenHeaps self-assigned this Aug 2, 2022
StephenHeaps added a commit that referenced this issue Aug 2, 2022
Fix `CryptoStore` not refreshing pending transactions on network change. Update `TransactionConfirmationStore` / `TransactionConfirmationView` to show the full network name for the transaction.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant