Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add Bridge to Aurora button on asset detail screen #5785

Closed
jamesmudgett opened this issue Aug 4, 2022 · 3 comments · Fixed by #5873
Closed

Add Bridge to Aurora button on asset detail screen #5785

jamesmudgett opened this issue Aug 4, 2022 · 3 comments · Fixed by #5873

Comments

@jamesmudgett
Copy link
Contributor

jamesmudgett commented Aug 4, 2022

Android version of brave/brave-browser#24377

Add "Bridge to Aurora" button on all supported assets (this screen shows all supported assets including both highlighted and not highlighted)

Image

Example placement

Image

First time tapping on bridge button

Image

(Lets show a system dialog that informs the user of the risks, the learn more button should be a system button and not a link in the message body. Three buttons [Continue, Cancel, Learn more], learn more link https://ethereum.org/en/bridges/#bridge-risk)

@nuo-xu
Copy link
Contributor

nuo-xu commented Aug 15, 2022

as discussed in wallet channel we will show aurora bridge button for tokens
if the token has a bridge address or the token is a native token, and the token chainId is eth mainnet

nuo-xu added a commit that referenced this issue Aug 25, 2022
@nuo-xu nuo-xu added the QA/Yes label Sep 6, 2022
@iccub iccub added this to the 1.59 milestone Oct 6, 2023
@nuo-xu nuo-xu removed this from the 1.59 milestone Oct 6, 2023
@nuo-xu
Copy link
Contributor

nuo-xu commented Oct 6, 2023

keep 1.59 milestone since it has been shipped out in 1.43 but not verified

@nuo-xu nuo-xu added this to the 1.59 milestone Oct 6, 2023
@srirambv
Copy link
Contributor

Verification passed on iPhone 13 with iOS 17.2 running 1.60 (23.11.12.17)

  • Verified steps from #5873
  • Verified Bridge to Aurora button is shown on supported tokens
  • Verified Bridge to Aurora button is not shown on unsupported tokens
  • Verified Bridge to Aurora button is only shown for Ethereum Mainnet
  • Verified selecting Do not show again doesn't show the permission prompt when selecting Bridge to Aurora button
  • Verified Learn more about using Rainbow Bridge loads https://doc.aurora.dev/bridge/bridge-overview/
  • Verified Learn how to reduce risk on Rainbow Bridge loads https://rainbowbridge.app/approvals`
5785.MP4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.