Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Sync chain flow via tab sync displayed in landscape [iOS 16] #6275

Closed
Uni-verse opened this issue Oct 27, 2022 · 1 comment · Fixed by #8485
Closed

Sync chain flow via tab sync displayed in landscape [iOS 16] #6275

Uni-verse opened this issue Oct 27, 2022 · 1 comment · Fixed by #8485

Comments

@Uni-verse
Copy link
Contributor

Description:

In landscape view, user is not forced to portrait when sync chain modals are displayed via tab sync flow. Instead, sync chain modals are displayed in landscape which results in some elements not shown correctly as we display these flow in portrait only.

We should fix this flow for landscape on iOS 16 or force portrait mode to avoid potential usability issues

Steps to Reproduce

  1. Fresh profile
  2. Open tab tray, select tabs from other devices segmented tab
  3. Rotate device to landscape
  4. Tap on Start a sync chain
  5. Sync modal will display in landscape
  6. Select Select the Tablet or Phone option
  7. Observe
  8. Delete sync chain
  9. Repeat steps.. this time choose I have a sync code
  10. Notice the scan modal in landscape is not displayed correctly

Actual result:
Sync chain modals are not displayed in portrait view.

Example Example
IMG_3981 IMG_3982

Expected result:
We should fix this flow in landscape or force portrait to avoid potential usability issues

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easily

Brave Version:
1.45.x

Device details:
iPhone 12 Pro, iOS 16.x

@Uni-verse
Copy link
Contributor Author

Verified on iPhone X running iOS 16.7and iPad (7th Gen) running iPadOS 17.0 using version 1.61 (23.12.11.17)

  • Ensured all flow screens are forced to display in portrait in the segmented tab sync flow.
  • Ensured joining sync chain using code words and scanning QR code is successful.
  • Spot checked sync flow on iPad to ensured nothing has regressed.
  • Ensured Sync Internals data is populated after joining sync chain.

Case 1: Start a new Sync Chain

Example Example Example Example Example
IMG_3663 IMG_3664 IMG_3665 IMG_3666 IMG_3667

Case 2: I have a Sync Code

Example Example Example
IMG_3664 IMG_3668 IMG_3669

Case 3: iPad (spot check)

Example Example Example Example Example
IMG_1254 IMG_1255 IMG_1256 IMG_1257 IMG_1258

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.