Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Show transactions from all networks on activity tab #7233

Closed
StephenHeaps opened this issue Apr 12, 2023 · 1 comment · Fixed by #7441
Closed

Show transactions from all networks on activity tab #7233

StephenHeaps opened this issue Apr 12, 2023 · 1 comment · Fixed by #7441

Comments

@StephenHeaps
Copy link
Contributor

Currently we are only able to fetch all transactions for the selected network for each coin type. A core change is in progress to give us the ability to fetch transactions for all networks instead of just the selected network. When this is available, we should add an accounts & network filter to the Activity tab.

Discussion ref: https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1680806641725749

Accounts filter should default to All Accounts and network filter should default to All Networks.

Empty State:
Screenshot 2023-04-04 at 10 36 08 AM

With Transactions:
Screenshot 2023-04-04 at 10 37 26 AM

blocked until brave/brave-browser#29638 is available.

@StephenHeaps StephenHeaps added blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue Epic: Brave Wallet labels Apr 12, 2023
@StephenHeaps StephenHeaps removed the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label May 5, 2023
@nuo-xu nuo-xu self-assigned this May 8, 2023
@nuo-xu nuo-xu added the QA/Yes label May 8, 2023
@iccub iccub added this to the 1.52 milestone Jun 16, 2023
@srirambv
Copy link
Contributor

Verification passed on iPhone 13 with iOS 16.5 running 1.52 (23.6.22.18)

  • Verified steps from #7441
  • Verified all completed transaction activity from all network is shown under activity tab
  • Verified rejected transactions are only shown under the account and not under activity tab
7233.MP4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants