Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Open Tabs Session Time hour format display error #7410

Closed
soner-yuksel opened this issue May 8, 2023 · 1 comment · Fixed by #7411
Closed

Open Tabs Session Time hour format display error #7410

soner-yuksel opened this issue May 8, 2023 · 1 comment · Fixed by #7411

Comments

@soner-yuksel
Copy link
Contributor

Description:

The proper @4 hr time should be displayed in Open Tabs screen

Steps to Reproduce

  1. Sync Open Tabs
  2. Check hour display on session

Actual result:

24 hr time is displayed but also am/pm

Expected result:

Hour should be displayed properly on 24 hr

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight? 💯
  • Can you reproduce this issue with the previous version of the current build from TestFlight? 💯
  • Can you reproduce this issue with the current build from AppStore? 💯

Device details:

N/A

Website problems only:

  • did you check with Brave Shields down? N/A
  • did you check in Safari/Firefox (WkWebView-based browsers)? N/A
@hffvld
Copy link
Collaborator

hffvld commented Jun 13, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 16.5] 
Version: 1.52 (23.6.9.13)
BraveCore: 1.52.117 (114.0.5735.90)

12 hour format - PASS

STEPS:

  1. Disable 24-Hour Time in device settings
  2. Launch Brave > Tab tray
  3. Choose Tabs from Other Devices > Turn on Sync > Verify

ACTUAL RESULTS:

  • Verified that the time format is shown correctly on Tabs from Other Devices screen when a 24-hour format is disabled
1 2
1 2
24 hour format - PASS

STEPS:

  1. Enable 24-Hour Time in device settings
  2. Launch Brave > Tab tray
  3. Choose Tabs from Other Devices > Turn on Sync > Verify

ACTUAL RESULTS:

  • Verified that the time format is shown correctly on Tabs from Other Devices screen when a 24-hour format is enabled
1 2
1 2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants