Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Playlist Revamp: URL bar icons & menus #7422

Closed
kylehickinson opened this issue May 9, 2023 · 1 comment · Fixed by #7423
Closed

Playlist Revamp: URL bar icons & menus #7422

kylehickinson opened this issue May 9, 2023 · 1 comment · Fixed by #7423

Comments

@kylehickinson
Copy link
Collaborator

See Figma: iOS Playlist

Should replace the icons used for playlist, along with change the popover when adding an item and showing a menu when tapping an added item that allows for quickly changing where the video is saved, remove/undo and opening in playlist

@hffvld
Copy link
Collaborator

hffvld commented Jun 27, 2023

Verified on iPhone 14 and iPad Airusing version(s):

Device/OS: iPhone 14 [iOS 16.5] and iPad Air [iPadOS 16.4.1]
Version: 1.52 (23.6.22.18)
BraveCore: 1.52.125 (114.0.5735.110)

Filed follow-up issue #7644


STEPS:

  1. Fresh install Brave > Launch Brave > Open www.youtube.com > Verify
  2. Tap on Watch the video > Verify
  3. Return to www.youtube.com > Open any video > Tap Save to playlist button > Verify
  4. Add another video to a playlist > While toast notification is shown, tap Change > Verify
  5. Tap Add to playlist button once again for the file that is already in the playlist > Verify
  6. While the popover menu is opened, tap Remove > Verify
  7. Tap Undo > Verify
  8. While the popover menu is opened, tap Change Playlist > Verify
  9. While the popover menu is opened, tap Open In Playlist > Verify

ACTUAL RESULTS:

  • Verified that the pop-up is shown for the first landing on www.youtube.com
  • Verified when tapping on Watch the video link, brave.com/playlist is opened
  • Verified that Add to playlist button is working and video is added to a default playlist
  • Verified that the toast notification is hidden ~4 seconds after the file is added to a playlist
  • Verified that Move to UI is opened and the user can create a new playlist and move files between them
  • Verified that the popover menu is opened when tapping Add to playlist for a file that is already in the playlist
  • Verified that tapping Remove is removing the file from the playlist
  • Verified that it's possible to Undo delete action
  • Verified that Move to UI is opened and the user can create a new playlist and move files between them
  • Verified that the current playlist is opened and the video starts playing from the moment where it was stopped playing last time
iPhone
1 2 3 4
1 2 3 4
5 6 7 8
1 2 3 4
iPad Air
1 2 3 4
1 2 3 4
5 6 7 8
1 2 3 4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.